Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map volumes to persistent paths in example compose files #3654

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

he3als
Copy link

@he3als he3als commented Mar 26, 2024

The documentation currently includes example docker-compose.yml files that will clear users' NPM data when the server is re-deployed, which can confuse, e.g., this Reddit post.

This pull request makes the example compose files instead save to a persistent location, /srv/nginx-proxy-manager.

@nginxproxymanagerci
Copy link

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-3654

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21
Copy link
Member

jc21 commented Apr 19, 2024

I disagree with this change. The docker-compose example will create persistent, mounted volumes relative to the CWD when the compose up is run. The only way these volumes are wiped out is when running compose down or if the CWD is itself a temporary FS.

The reddit post does not determine why mounting an absolute folder worked for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants