Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use client provided header to determine access protocol #3589

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

realies
Copy link

@realies realies commented Feb 27, 2024

this helps when using tunnels like cloudflared and fixes #3365

@nginxproxymanagerci
Copy link

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-3589

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21
Copy link
Member

jc21 commented Feb 27, 2024

I believe that this approach will only work when NPM is behind another proxy, like Cloudflare as per the issue. However, might have unexpected problems when hitting directly.

@jc21 jc21 added the requires-verification Waiting for one or more people to confirm the fix label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-verification Waiting for one or more people to confirm the fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

force ssl with cloudflared not working
2 participants