Combat/Core: Damage Calculator & Combat Log support #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base damage methods added to DamageCalculator CombatResult calculations added Armor mitigation calculations CombatLogs support Use Any() instead of Count() Fix - Combat/DamageCalculator: Mitigation calc
Lumbendil
force-pushed
the
damage-calculations
branch
from
9d2eb9f
to
87d5b6a
Compare
|
I assume the second DamageCalculator in the world server should be removed? |
Hey! Sorry that I left this like that. I'll check it, but it seems likely yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of the PR #324