[Item/Runes] Support Runes and Rune Slots #399
+3,594
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randomly generates Rune Slots as appropriate for the given item Insert & Remove Runes from RuneSlots Add the extra Rune Slot to items Reroll Rune Slots Stat calculations are not in yet Fix Rune Insert logic
kirmmin
force-pushed
the
rune-support
branch
from
19ffce6
to
00b98e1
Compare
steventmayer
reviewed
Jan 1, 2022
| continue; | ||
|
|
||
| // Rune Socket must be empty to place a rune in it, error. | ||
| if (item.Runes[i].RuneItem != null) |
There was a problem hiding this comment.
Hi @kirmmin I truly miss Wildstar, but not great at network/lower level code, so I was hoping I could help with your PRs. If you'd rather me not, just let me know.
Do we want to check for null prior to checking if the runeitem is the same (964)? It's minor either way.
steventmayer
reviewed
Jan 1, 2022
|
|
||
| if (recover) | ||
| { | ||
| if (GetInventorySlotsRemaining(InventoryLocation.Inventory) < 1u) |
There was a problem hiding this comment.
it's been a while so apologies. Are runes stackable? If they are, we may want to check if || HasItem(item.Runes[socketIndex].RuneItem.Id)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomly generates Rune Slots as appropriate for the given item
Insert & Remove Runes from RuneSlots
Add the extra Rune Slot to items
Reroll Rune Slots
Stat calculations are not in yet
Thanks to @brannon-penrod for their help with the binary math calculations.