[Guilds/Communities] Handle Residence(s) on Disband or Leave #391
+116
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Community Visit list appropriately on Disband Fix Players not having a Residence assigned to ResidenceManager when Residence is created Update Communitiy Visit List on Map Enter in case Community was just disbanded
Rawaho
reviewed
Dec 5, 2021
| @@ -89,6 +89,7 @@ protected override void AddEntity(GridEntity entity, Vector3 vector) | |||
| if (entity is not Player player) | |||
| return; | |||
|
|
|||
| GlobalResidenceManager.Instance.SendRandomVisitableCommunities(player.Session); | |||
There was a problem hiding this comment.
Any reason this is being sent here?
The client has a packet it sends to request this when the random property window is open.
There was a problem hiding this comment.
Sorry, I hadn't seen this comment.
I wrote this in here because if a Community is Disbanded, anybody in the current Community Map is removed and then sent to their own plot. When they reload, if they click on the "View Visitable Communities" thing, the old Community shows up because it's using the values from the first time the window was loaded. I discovered that re-sending the visitable communities was all that was needed to remove the, now disbanded, community.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Community Visit list appropriately on Disband
Fix Players not having a Residence assigned to ResidenceManager when Residence is created
Update Communitiy Visit List on Map Enter in case Community was just disbanded