Entity/AI: Range tracking other entities #330
Conversation
Refactored to use more standard methods Code tidy Further tidy Refactored further for better tracking
Refactored to use more standard methods Code tidy Further tidy Refactored further for better tracking
| if (!(entity is WorldEntity we)) | ||
| return; | ||
|
|
||
| if (!(this is Player)) |
There was a problem hiding this comment.
This should be an override in player.
| /// </summary> | ||
| protected bool HasEnteredRange(WorldEntity target) | ||
| { | ||
| return inRangeEntities.Keys.Contains(target.Guid); |
There was a problem hiding this comment.
| return inRangeEntities.Keys.Contains(target.Guid); | |
| return inRangeEntities.ContainsKey(target.Guid); |
There was a problem hiding this comment.
Could you elaborate on the difference here? I assume one is native and one is LINQ?
There was a problem hiding this comment.
Yeah, so, I double checked here, because I remembered something from older .NET versions.
dict.ContainsKey is going to do a O(1) lookup in the dictionary.
dict.Keys.Contains will do a linear aka O(n) lookup due to the fact that KeyCollection is not a hash-based collection, but just an array.
But it seems like dict.Keys.Contains is the same on .NET 5 (and older versions?) https://source.dot.net/#System.Private.CoreLib/Dictionary.cs,1424
There was a problem hiding this comment.
Also, one of my usual preferred reasons is: reduced cognitive load.
Dictionary.ContainsKey is a pretty standard API and well known behaviour.
By adding .Keys, there are increased considerations to take into account, like Keys implementation and behaviour.
There was a problem hiding this comment.
If there is no performance benefit, I'll leave it up to @Rawaho to decide the best choice for this so that it stays consistent with rest of framework
There was a problem hiding this comment.
O(1) vs O(n) is a big difference tho, ContainsKey is the better way here.
Refactored to use more standard methods Code tidy Further tidy Refactored further for better tracking
No description provided.