Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Party/Feature: Initial implementation #322

Open
wants to merge 1 commit into
base: game_rework
Choose a base branch
from
Open

Party/Feature: Initial implementation #322

wants to merge 1 commit into from
+3,207 −3

Conversation

MaxtorCoder
Copy link
Contributor

@MaxtorCoder MaxtorCoder commented Oct 5, 2020 •
edited

Features

  • Group
    • Group Creation
    • Member adding
    • More soon

Todo:

  • Request Join (In Progress)
  • Kick Member
  • Leave Group
  • Convert to Raid
  • Save group and members in Database (for disconnect/server crash)
  • Player/Unit marking
  • Display member on map
  • Promote group member

Authors

@MaxtorCoder MaxtorCoder marked this pull request as ready for review January 4, 2021 12:24
@MaxtorCoder MaxtorCoder changed the title Party/Feature: Initial implementation - WIP Party/Feature: Initial implementation Jan 4, 2021
@kirmmin
Copy link
Member

kirmmin commented Aug 11, 2021

If you wouldn't mind me merging this into my latest branch, is it possible to have this PR rebased onto develop and have it's commit history squashed, please?

@MaxtorCoder
Copy link
Contributor Author

If you wouldn't mind me merging this into my latest branch, is it possible to have this PR rebased onto develop and have it's commit history squashed, please?

I'll see what I can do today. 😄

@MaxtorCoder
Copy link
Contributor Author

@kirmmin Done :)

@Rawaho Rawaho added this to the Pull Request Cleanup milestone Jan 16, 2023
@MaxtorCoder MaxtorCoder changed the base branch from develop to game_rework May 7, 2023 08:57
@Rawaho
Copy link
Member

Rawaho commented Jul 24, 2023

Rebased to game_rework branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Therzok Therzok Therzok left review comments

@alex-anderson156 alex-anderson156 alex-anderson156 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pull Request Cleanup
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MaxtorCoder @kirmmin @Rawaho @Therzok @alex-anderson156