Quests/Core: Checklist quests support - WIP #283
+2,891
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rawaho
reviewed
May 23, 2020
| /// <summary> | ||
| /// Builds the target ID list for this <see cref="QuestObjective"/>. | ||
| /// </summary> | ||
| private void BuildTargets() |
There was a problem hiding this comment.
Does this need to be built for every player objective? Could this not be cached?
There was a problem hiding this comment.
Refactored the build to AssetManager and then the QuestObjective grabs its list if it should :)
kirmmin
force-pushed
the
quest-checklists
branch
2 times, most recently
from
d37aad8
to
912f044
Compare
kirmmin
added a commit
to kirmmin/NexusForever
that referenced
this pull request
Sep 29, 2020
kirmmin
force-pushed
the
quest-checklists
branch
4 times, most recently
from
6014d13
to
900eefa
Compare
Added comment to explain QuestChecklistIdx Fix Reputation value Fix erroneous build targets Fix: Quest Completion with optional objectives Fix: Single required objective check Fix: Quest objectives complete check
kirmmin
force-pushed
the
quest-checklists
branch
from
900eefa
to
902a87a
Compare
|
This PR needs updating with code from this commit: kirmmin@d9b4c0a |
kirmmin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #306
For this to function properly, entities that are part of a Checklist Quest will need to have their database entries updated/re-dumped with the
QuestChecklistIdxfrom a sniff included.This is used in quests like the Housing Starting Quest (Exile: http://www.jabbithole.com/quests/housing-of-the-future-9160) where you have to interact with certain entities and they update the quest appropriately.
This also includes the Reputation Rewards being sent to the Player after completing a quest.