Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding time grid widget #302

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Contributor

The idea is to have a quick visual representation of how the timing of the objects stands in regard to each other. I put this together quickly, so I'm very open to stylistic and other suggestions. I tested this against the Valero Conversion from the Buzsaki lab, and also used another dataset using Panel.

I'm also uncertain about the best placement for this, so right now it sits between the header data and the accordion. I'm not clear on how it could be in the accordion as this maps directo to the nwbfile and not to a sub-type...

This does not have a lot of functionality - and I think it probably should not - but I added the possibility of having epoch guides for orientation. I also thought that it might be a good idea to have an option to mark the trials, but I was concerned that this would be more computationally costly and I didn't have a lot of time to put this together.

This is using panel:
image

And this is using a local example with more structure:

output.mov

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #302 (f7a4add) into master (2adfb8a) will decrease coverage by 0.74%.
The diff coverage is 48.66%.

❗ Current head f7a4add differs from pull request most recent head 8b8d6b4. Consider uploading reports for the commit 8b8d6b4 to get more accurate results

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   66.22%   65.48%   -0.74%     
==========================================
  Files          35       36       +1     
  Lines        3458     3607     +149     
==========================================
+ Hits         2290     2362      +72     
- Misses       1168     1245      +77     
Flag Coverage Δ
unittests 65.48% <48.66%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbwidgets/time_grid.py 47.61% <47.61%> (ø)
nwbwidgets/file.py 71.42% <100.00%> (+1.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants