Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker/Panel fixes and improvements #299

Merged
merged 32 commits into from
Jul 21, 2023
Merged

Conversation

luiztauffer
Copy link
Collaborator

@luiztauffer luiztauffer commented Jun 27, 2023

  • fix requirements for Dockerfile
  • improve docker/readme
  • github action to build and publish Image on new releases
  • local mount option, depends on Better local file component #300

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@057cfed). Click here to learn what that means.
The diff coverage is 57.14%.

@@            Coverage Diff            @@
##             master     #299   +/-   ##
=========================================
  Coverage          ?   66.22%           
=========================================
  Files             ?       35           
  Lines             ?     3467           
  Branches          ?        0           
=========================================
  Hits              ?     2296           
  Misses            ?     1171           
  Partials          ?        0           
Flag Coverage Δ
unittests 66.22% <57.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbwidgets/panel.py 76.96% <53.84%> (ø)
nwbwidgets/version.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luiztauffer luiztauffer marked this pull request as ready for review June 27, 2023 11:27
@bendichter
Copy link
Collaborator

lgtm! @CodyCBakerPhD could you take a look as well since you know more about this type of devops stuff?

@CodyCBakerPhD
Copy link
Collaborator

Yes, I've been keeping my eye on it and will make some comments later as I notice a couple things while adding similar stuff to catalystneuro/neuroconv#383

@luiztauffer
Copy link
Collaborator Author

@CodyCBakerPhD any specific things you see that should be blocking this merge? I wanted to get the dockerized mode updated and start releasing the images alongside the pypi releases, it will make it very easy to run Panel remotely always with the latest updates

docker/Dockerfile Outdated Show resolved Hide resolved
bendichter
bendichter previously approved these changes Jul 21, 2023
nwbwidgets/version.py Outdated Show resolved Hide resolved
@luiztauffer luiztauffer merged commit ab16a5f into master Jul 21, 2023
10 checks passed
@luiztauffer luiztauffer deleted the panel-fixes-and-improvements branch July 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants