Psth use intervals #200
Open
Psth use intervals #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/test_controllers.py
* correct base where units was used accidentally instead of the generic input_data * add route_psth, which decides between a standard PSTHWidget and a PSTHWidget inside a TimeIntervalsSelector wrapper * change view to use new routing function
* use positional arg for the first arg of TimeIntervalsSelector
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 67.72% 67.87% +0.14%
==========================================
Files 32 32
Lines 2947 2976 +29
==========================================
+ Hits 1996 2020 +24
- Misses 951 956 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More intelligently handle intervals for widgets that take them:
I'd like to hone this for PSTHWidgets and then factor it out so this logic can be used for any widget that uses intervals