Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icephys accordions with AlignedDynamicTable and renamings #107

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lvsltz
Copy link

@lvsltz lvsltz commented Jun 8, 2020

There have been some major changes since February in ndx-icephys-meta and this PR syncs nwb-jupyter-widges with that extension:

  • some tables have been renamed
  • IntracellularRecordingsTable is now an AlignedDynamicTable

@bendichter
Copy link
Collaborator

@lvsltz thanks, these changes look great!

Do you know if these changes were associated with version numbers? I'm worried that after we make these changes someone might install an older version of ndx-icephys-meta and then have the opposite problem. The best way to avoid this is to explicitly enforce specific versions in the requirements or setup.py files. I'll take a look at the ndx-icephys-meta repo to see if we can refer to specific release versions.

@bendichter
Copy link
Collaborator

It looks like the last (and only) release was Feb 3, and many of these changes were made March 3-4, so they are unreleased. In general, I only want to depend on released code (on pypi), so I'm going to wait to merge this until those changes are in an official pypi release. Also, I'm going to add a version constraint for when this is eventually merged.

@bendichter bendichter marked this pull request as draft June 8, 2020 13:01
@lvsltz
Copy link
Author

lvsltz commented Jun 8, 2020

Indeed, it makes sense to wait. I overlooked the pypi release.

@bendichter
Copy link
Collaborator

This is very helpful nevertheless! Thanks for helping me keep on top of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants