started alias of main package for imports #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjare
reviewed
Apr 14, 2024
| from eegnb.analysis.utils import * | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
You should specify a __all__ variable here with the intended "exports" of the package (what will be imported with from eegexpy import *).
There was a problem hiding this comment.
Can you elaborate?
I had hoped the import * would give me all of the eegnb imports and that would be the only line needed
In practice that didn't work. Unclear why. From reading it seemed it could be that the modules inside eegnb are doing relative imports. So it looks like I will need to explicitly do a load of imports in this init to get it to mirror eegnb
|
merging for now as I want to do a demo :S can continue to assess the imports question |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just need to have a top-level folder
eegexpyand then add relative imports through an
__init__.pyprobably are going to have a lot of stuf in that
__init__.py