-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update account tests to sepolia #558
Conversation
Just two general points:
|
I used existing transactions which were similar to the goerli ones. So these were real transactions I found on the block-explorer. But some of them don't seem to exist anymore. (I'd picked the most recent ones that matched) For the other tests also, I've used real sepolia data. But you're right. I need to create new transactions here, with a test wallet. I'll get to this asap! |
6acc19d
to
1887bdc
Compare
account/account_test.go
Outdated
@@ -795,7 +729,7 @@ func TestTransactionHashInvokeV3(t *testing.T) { | |||
testSet := map[string][]testSetType{ | |||
"mock": { | |||
{ | |||
// https://external.integration.starknet.io/feeder_gateway/get_transaction?transactionHash=0x49728601e0bb2f48ce506b0cbd9c0e2a9e50d95858aa41463f46386dca489fd | |||
// https://external.integration.starknet.io/feeder_gateway/get_transaction?transactionHash=0x473e7d9dcaf02b5bbc2f89486fb2e23241f645cd55f70ff02576b79541befe7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't find this line in the code. Hence, considered fixed.
7f3209c
to
f009497
Compare
account/account_test.go
Outdated
{ | ||
CairoVersion: 0, | ||
ChainID: "SN_GOERLI", | ||
ChainID: "SN_SEPOLIA", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this testdata is from goerli, we can just remove this
account/account_test.go
Outdated
require.NoError(t, err) | ||
|
||
var casmClass contracts.CasmClass | ||
err = json.Unmarshal(content2, &casmClass) | ||
require.NoError(t, err) | ||
compClassHash := hash.CompiledClassHash(casmClass) | ||
|
||
nonce, err := acnt.Nonce(context.Background(), rpc.BlockID{Tag: "latest"}, acnt.AccountAddress) | ||
require.NoError(t, err) | ||
// nonce, err := acnt.Nonce(context.Background(), rpc.BlockID{Tag: "latest"}, acnt.AccountAddress) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this if it's not being used
Partially resolves #544