Issue#63 - Adding Nullable checks #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-sonthalia
commented
Feb 23, 2024
•
shubham-sonthalia
commented
Open
flcl42
reviewed
Feb 23, 2024
added 2 commits
February 24, 2024 00:22
|
Hey @flcl42, for the solution level, I was previously getting 60 warnings. I have reduced them down to 25 now. But now, I am not sure about the null checks because they are causing some other issues when adding nullables there. |
You can propose solution and let me help you with comments |
flcl42
reviewed
Feb 26, 2024
| } | ||
| if (!channel.IsClosed) | ||
| if (channel != null && !channel.IsClosed) |
There was a problem hiding this comment.
channel is not nullable, so you can omit this check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.