[zuul-core] Replace http only channel initializer with ALPN based #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argha-c
changed the title
|
This is a breaking change and could impact users that don't want to run SSL-based servers. EDIT: also breaks use cases that don't want/need ALPN/HTTP2 |
| @@ -51,18 +51,6 @@ | |||
| private final SwallowSomeHttp2ExceptionsHandler swallowSomeHttp2ExceptionsHandler; | |||
| private final String metricId; | |||
|
|
|||
|
|
|||
| /** | |||
| * Use {@link #Http2SslChannelInitializer(String, ChannelConfig, ChannelConfig, ChannelGroup)} instead. | |||
There was a problem hiding this comment.
The reason this is deprecated (and not deleted) is because this is a backward incompatible change.
There was a problem hiding this comment.
Well, the reason we deprecate is to eventually be able to remove.
I see this was only deprecated recently. We should probably make the deprecation window explicit.
There was a problem hiding this comment.
Yeah, I would cut a minor release, then probably make this change. It's not actually semver, but it's enough to be able to upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces SSL based initialization, with ALPN based swapping of the appropriate protocol handlers.
Edit: This is likely a breaking change, for those relying on the non-SSL based http only initializer today.