Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore io_uring unit test #1214

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Feb 27, 2022

Let's try using 'sudo -E' in the snapshot workflow

Reference

https://man7.org/linux/man-pages/man8/sudo.8.html

-E

Indicates to the security policy that the user wishes 
to preserve their existing environment variables.

@sullis sullis changed the title restore unit test: IoUringTest restore io_uring unit test Feb 27, 2022
@sullis
Copy link
Contributor Author

sullis commented Feb 27, 2022

@argha-c I don't have a good way to test this. Can you review it?

@sullis
Copy link
Contributor Author

sullis commented Mar 10, 2022

@argha-c I don't have a good way to test this. Can you review it?

WDYT?

@sullis
Copy link
Contributor Author

sullis commented Apr 14, 2022

@argha-c WDYT?

@argha-c
Copy link
Collaborator

argha-c commented Apr 14, 2022

@argha-c WDYT?

I think we need to a simple way to verify that failing to set the ulimit does not break the snapshot publishing.
As an alternative, we could consider running that test under a separate stage. No strong opinions as long as we confirm the snapshot publish is intact.

@argha-c argha-c self-requested a review April 15, 2022 15:19
@sullis sullis force-pushed the IoUringTest-restore-sean branch 2 times, most recently from 060cbce to 619f359 Compare October 23, 2022 01:53
Let's try using 'sudo -E' in the snapshot workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants