This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
ECS deploy #1054
Open
ECS deploy #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be very interested in the docs. |
|
I'm definitely looking into an ECS Fargate deployment. Any chance for further progress on this PR? |
|
I have Security Monkey running on ECS in prod based on this PR so I'll have a dig tomorrow and see if I made any major changes |
|
I never pursued the Fargate changes @badllama, as the ECS deployment was functional and cheaper. |
|
The only missing item is a script to create the ECS services/cluster. But I don't have the time to create that now. @mikegrima I am fine with this being merged now, especially since it worked for @ollytheninja. But I leave it up to you. |
|
Can you do me a favor and rebase it with the latest develop? |
- Add env var for celery worker count - Remove blank AWS keys from env (confuses ECS) - Add ecs_push script for updating ECS env - Modify docker start scripts to crash on error - Add docker compose files for each service set -
tabletcorry
force-pushed
the
ecs_deploy
branch
from
8d73fd3
to
c60a5f3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, I tease the existing docker-compose file into three parts, for the major services that need to run in production. In order to function, the env files need to specify all the required variables in the new yaml files. I will document this.
This isn't perfect. An alternative solution would be to build the component compose files "on-the-fly" by parsing the base compose YAML. That may be the evolution of this change, but I wanted to prove out the basic ECS deployment.
Comments very welcome. I don't think this is merge-worth just yet, so I am interested in thoughts from the SM maintainers.
Changes:
Todo: