Publish new name on table rename event #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insyncoss
force-pushed
the
sns
branch
2 times, most recently
from
79bacb7
to
80cb5a3
Compare
stevie9868
approved these changes
May 7, 2024
| @@ -51,8 +55,10 @@ public RenameTableMessage( | |||
| @JsonProperty("timestamp") final long timestamp, | |||
| @JsonProperty("requestId") final String requestId, | |||
| @JsonProperty("name") final String name, | |||
| @JsonProperty("payload") final UpdatePayload<TableDto> payload | |||
| @JsonProperty("newName") final String newName, | |||
| @Nullable @JsonProperty("payload") final UpdatePayload<TableDto> payload | |||
There was a problem hiding this comment.
Wondering why do we want to have the payload be Nullable?
There was a problem hiding this comment.
In case the initial send fails, for example if full payload causes message to be too long, then the fallback is send the message again except null payload.
amboz
approved these changes
May 8, 2024
ajoymajumdar
reviewed
May 8, 2024
| return new RenameTableMessage( | ||
| id, | ||
| timestamp, | ||
| requestId, | ||
| name.toString(), | ||
| newName == null ? "" : newName.toString(), |
There was a problem hiding this comment.
Why not set it to null if null?
There was a problem hiding this comment.
Setting to null instead of empty string if null would be fine as well. If defaulting to null instead of empty string here helps on the client side then we can make that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish new name on table rename event, and add publish of new name in case of SNS message send failure as well. This allows clients to properly be notified of new name after rename event even in case of initial send failure.