Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus metrics for Genie #1203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbock-slack
Copy link

@sbock-slack sbock-slack commented Mar 27, 2024

  • Add dependencies to Genie that are needed to support the /admin/prometheus endpoint.

  • We've built our own JARs and are already using Prometheus to power our metrics around Genie's health. Hoping to remove the need for us to locally fork Genie by getting this into open source 馃憤

@babourine-slack
Copy link

馃憢 Hi @bhou2 ! Thank you for hard work on maintaining Genie! Was wondering if we could get some traction on this PR? Will be happy to adjust it if needed and will appreciate an approx ETA so we could adjust accordingly.

@bhou2
Copy link
Contributor

bhou2 commented Apr 30, 2024

Thanks @babourine-slack I did not get the notification about this PR in the past several weeks. Checking.

Copy link
Contributor

@bhou2 bhou2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify the tests you have done?

@babourine-slack
Copy link

babourine-slack commented May 14, 2024

Could you clarify the tests you have done?

We built it locally with all tests as well as running it in prod for weeks now w/o any issues. If there is any specific process that we should follow to contribute we'll be happy to do. There are two areas we would like to contribute in:

  • Modernize docker container that goes to the dockerhub (primarily because of the number of critical security issues baked into it)
  • Bump versions of some dependencies up as unfortunately the current jars carry many critical CVEs due to those dependencies. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants