Refactoring how graphiql is loaded and supporting subscriptions #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example: /PATH?path=/graphql&wsPath=/subscription
|
Thanks for the PR. I'll take a look at the PR next week. In the meantime, could you please run |
|
@StringKe - the tests seem to be failing with your changes. Could you please take a look at those as well when you can? |
Okay, I'm going to need to delay this for a couple days. |
|
Thanks, no rush at all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
first
Pull Request type
Changes in this PR
#1633
Originating this discussion, I need to test the subscription in graphiql, but it doesn't seem to be supported at the moment?
After the change, graphiql will load the http and subscription endpoints from the url and use them, and parameters such as query will be serialized and displayed on the url!
When a user requests a graphiql that does not carry any endpoint parameters, it automatically adjusts to the address that does!
I'm testing the corresponding code in my own project webflux This implementation does not have any errors and can perform subscriptions.
I'm not familiar with webmvc / webflux, and I'm not a very skilled java / kotlin development engineer, so if there's anything wrong with this pr, feel free to submit changes!
Alternatives considered
None