Fix LinearRing Type on Polygon Class

[Jeongyong-park]

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following the existing coding patterns and practice as demonstrated in the repository.

• I have provided test coverage for my change (where applicable)

Description

It was LinearRing Type not LineString Type in Polygon Class of JTS

[CLAassistant]

All committers have signed the CLA.

[Jeongyong-park]

@dotnet-policy-service agree

[airbreather]

It was LinearRing Type not LineString Type in Polygon Class of JTS

Well, it was LineString until locationtech/jts#290.

This would be a breaking change, one which I would not be inclined to take because callers can always use:

• Shell instead of ExteriorRing
• Holes instead of InteriorRings
• Holes[n] instead of GetInteriorRingN(n)

[airbreather]

I expected the validation builds to reject this on the basis of the breaking change. It looks like a later version of the .NET SDK will enforce this rule, but it was implemented too recently to make it into the .NET 8.0 SDK (as of RC1):

• [API Compat] Changing a member return type should be detected as a breaking change dotnet/sdk#34864
• Validate member types dotnet/sdk#34872
• dotnet/sdk@6fad359

Edit: looks like it will be in .NET 8.0 SDK after all, starting with RC2, per:

• [release/8.0.1xx] Validate this extension methods and member types in APICompat dotnet/sdk#34999
• dotnet/sdk@e4d0b0a

[Jeongyong-park]

It was LinearRing Type not LineString Type in Polygon Class of JTS

Well, it was LineString until locationtech/jts#290.

This would be a breaking change, one which I would not be inclined to take because callers can always use:

• Shell instead of ExteriorRing
• Holes instead of InteriorRings
• Holes[n] instead of GetInteriorRingN(n)

Ok, It was LineString but now LinearRing Type. isn't it?

[FObermaier]

As @airbreather already said, if you need LinearRing now use Shell and Holes[idx] property.
This change has been omitted intentionally to avoid a breaking change.

I'd postpone this to the point where we consider doing a new major release. On that occasion we should remove Shell and Holes property, too.