add srsName to GML3 (optional) and all GML2 #575
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lvermeulen
reviewed
Dec 10, 2021
| [Test] | ||
| public void TestGML3Point() | ||
| { | ||
| var document = ToGML3(CreatePoint()); | ||
| var geometry = CreatePoint(); | ||
| var document = ToGML3(geometry); | ||
| AssertPoint(document); |
FObermaier
requested changes
May 24, 2023
| @@ -23,6 +22,8 @@ public class GMLWriter | |||
| private const int CoordSize = 200; | |||
| private readonly GMLVersion _gmlVersion; | |||
| private readonly string _gmlNs; | |||
| private readonly string _gmlSrsName = "srsName"; | |||
There was a problem hiding this comment.
private const string GmlSrsName = "srsName";
| protected virtual void WriteAttributeSrsName(int srid, XmlWriter xmlWriter) | ||
| { | ||
| if(_writeSrsNameAttribute) | ||
| xmlWriter.WriteAttributeString(_gmlSrsName, GetSrsName(srid)); |
There was a problem hiding this comment.
xmlWriter.WriteAttributeString(GmlSrsName, GetSrsName(srid));
| @@ -103,7 +106,7 @@ private static XDocument ToGML3(Geometry geom) | |||
| using var ms = new MemoryStream(); | |||
There was a problem hiding this comment.
Change signature to
private static XDocument ToGML3(Geometry geom, bool writeSrsName = true)
Duplicate at least one of the actual tests where writeSrsName is set to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Before I continue with the rest of the tests I would like your input to see if this could be approved.
This PR contains 2 changes to the GML writers.
srsNameattribute.Point,LinearString,LinearRing,Polygondidn't output thesrsNamewhile it looks required to me: http://schemas.opengis.net/gml/2.1.2/geometry.xsd .XSD isn't my strong suit, so might be mistaken. It looks like only members of the
MultiPolygonfor example are optional.Possible improvements:
Add new
ctorforGML3Writerthat would take a pattern as input for examplehttps://www.opengis.net/def/crs/EPSG/0/{0}.This would be vulnerable to injection so would have to check if it's a
urnorURI.Though this could be easily done by creating your own GML writer and inheriting from
GML3Writerand overridingGetSrsName.