Tarea #3301 agregar direccion a documentos compra #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguitarraverde
commented
Apr 23, 2024
| @@ -104,6 +114,19 @@ public static function assets() | |||
| } | |||
| } | |||
|
|
|||
| private static function addressField(Translator $i18n, PurchaseDocument $model, string $field, string $label, int $size, int $maxlength): string | |||
| { | |||
| $attributes = $model->editable && (empty($model->idcontactofact) || empty($model->direccion)) ? | |||
There was a problem hiding this comment.
@NeoRazorX aquí tengo dudas si en los proveedores se tienen que deshabilitar los inputs en algún momento o siempre se pueden quedar habilitados.
como he copiado varios metodos para pintar los inputs desde el SalesHeader, me he traido esta propiedad y no existe en los proveedores: $model->idcontactofact. deberia borrarla pero me deshabilita entonces los inputs
There was a problem hiding this comment.
Tampoco sé que es lo que hay que modificar al generar los PDF que se menciona en la tarea pero no he logrado ver que es lo que afecta a los nuevos campos de dirección.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripción
¿Cómo has probado los cambios?
Toda modificación debe haber sido mínimamente probada. Marca o describe las pruebas que has realizado: