p-adics done right #1746
Merged
p-adics done right #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
force-pushed
the
js/padic_done_right
branch
from
7d2bee1
to
3f91824
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1746 +/- ##
==========================================
+ Coverage 85.09% 85.32% +0.22%
==========================================
Files 95 95
Lines 36917 36903 -14
==========================================
+ Hits 31416 31487 +71
+ Misses 5501 5416 -85 ☔ View full report in Codecov by Sentry. |
lgoettgens
reviewed
May 7, 2024
joschmitt
force-pushed
the
js/padic_done_right
branch
3 times, most recently
from
fcc3b80
to
de68ed3
Compare
joschmitt
commented
May 10, 2024
joschmitt
commented
May 10, 2024
|
I think I have now everything we discussed. |
|
Looks good, let's discuss the Hecke breakage tomorrow. |
joschmitt
commented
May 15, 2024
| return g | ||
| end | ||
|
|
||
| function with_precision(f, K::QadicField, n::Int) |
Merged
joschmitt
force-pushed
the
js/padic_done_right
branch
from
a869897
to
c6dd543
Compare
Remove/deprecate some particularly "interesting" (and unused) functionality
Also make the precision a keyword argument
They redirect to `divexact` and this throws an error.
joschmitt
force-pushed
the
js/padic_done_right
branch
from
12590b2
to
cc2b639
Compare
|
This is good to go from my side. It would be good to have a patch release with this, so that I can use it in Hecke. |
|
Very good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeckeMoreStuffto the correct file + some testspadic_fieldandqadic_fieldwhere the precision is a keyword argumentprecisionkeyword arguments to all constructors which take exact inputprime_field(should never have been called like that) orlift(::PadicFieldElem)(lifts to ZZ, so one should calllift(ZZ, ...)) + more.