This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
Fix host collateral error when renewing contracts #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
fix-collateral
branch
2 times, most recently
from
c02d623
to
7caee39
Compare
ChrisSchinnerl
force-pushed
the
fix-collateral
branch
from
7caee39
to
19a4a4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure if this math makes sense but I'm pretty confident.
The comments were a bit misleading since it sounded like
basePriceandbaseCollateralare already covered by the last contract while they are actually the minimum amount of money that has to be put in the contract to cover the existing data on the host.In my opinion the
hostCollateralshould also be the possible max collateral + thebaseCollateral. That way we don't end up with a potential underflow later. It's also a bit more correct sincebaseCollateralis not a subset of thehostCollateralbut rather thehostCollateralis the sum of thebaseCollateral(collateral for existing data) plus themaxCollateral(the maximum additional collateral that will be put into the contract by the host if the renter spends all of therenterPayoutfor storage).