This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 442
Add support for offline transaction signing #2907
Open
lukechampine
wants to merge
29
commits into
master
Choose a base branch
from
offline-signing
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Mar 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d39e94f - Browse repository at this point
Copy the full SHA d39e94fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c7efd4 - Browse repository at this point
Copy the full SHA 1c7efd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fa416a - Browse repository at this point
Copy the full SHA 4fa416aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e959025 - Browse repository at this point
Copy the full SHA e959025View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6332d01 - Browse repository at this point
Copy the full SHA 6332d01View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3741e7 - Browse repository at this point
Copy the full SHA b3741e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41c5410 - Browse repository at this point
Copy the full SHA 41c5410View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32059e7 - Browse repository at this point
Copy the full SHA 32059e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 277d93a - Browse repository at this point
Copy the full SHA 277d93aView commit details
Commits on Mar 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 873500b - Browse repository at this point
Copy the full SHA 873500bView commit details -
Merge pull request #2913 from NebulousLabs/offline-signing-siatest
Add siatest and client integration for offline signing
Configuration menu - View commit details
-
Copy full SHA for 043674b - Browse repository at this point
Copy the full SHA 043674bView commit details -
Merge branch 'master' into offline-signing
Christopher Schinnerl committedMar 29, 2018 Configuration menu - View commit details
-
Copy full SHA for a2bcb24 - Browse repository at this point
Copy the full SHA a2bcb24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90566ab - Browse repository at this point
Copy the full SHA 90566abView commit details -
Configuration menu - View commit details
-
Copy full SHA for d408cc1 - Browse repository at this point
Copy the full SHA d408cc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4050676 - Browse repository at this point
Copy the full SHA 4050676View commit details
Commits on Apr 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 64ff690 - Browse repository at this point
Copy the full SHA 64ff690View commit details
Commits on Apr 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 78c2a13 - Browse repository at this point
Copy the full SHA 78c2a13View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2c89fc - Browse repository at this point
Copy the full SHA d2c89fcView commit details
Commits on Apr 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c5098c8 - Browse repository at this point
Copy the full SHA c5098c8View commit details -
Revert "include UnlockConditions in SpendableOutput"
This reverts commit c5098c8.
Configuration menu - View commit details
-
Copy full SHA for c1c14d7 - Browse repository at this point
Copy the full SHA c1c14d7View commit details
Commits on May 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0514348 - Browse repository at this point
Copy the full SHA 0514348View commit details
Commits on May 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 6b22c87 - Browse repository at this point
Copy the full SHA 6b22c87View commit details
Commits on May 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 477a497 - Browse repository at this point
Copy the full SHA 477a497View commit details -
Configuration menu - View commit details
-
Copy full SHA for c36c14e - Browse repository at this point
Copy the full SHA c36c14eView commit details
Commits on Jul 11, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 30a5854 - Browse repository at this point
Copy the full SHA 30a5854View commit details
Commits on Jul 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 83967e1 - Browse repository at this point
Copy the full SHA 83967e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fccafd - Browse repository at this point
Copy the full SHA 4fccafdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c97a9d7 - Browse repository at this point
Copy the full SHA c97a9d7View commit details -
In a nutshell, SignTransaction now does less work: it requires the user to fill out the UnlockConditions and TransactionSignatures of the transaction, whereas before it would fill them in itself. This is a better approach because it makes the most common operation -- signing all the inputs that the wallet controls -- dead simple. And requiring the user to fill out the unlock conditions isn't a big deal, because they can get those from /wallet/unspent. Lastly, if the user is responsible for filling out the TransactionSignature fields, they can control precisely what gets signed.
Configuration menu - View commit details
-
Copy full SHA for f174e41 - Browse repository at this point
Copy the full SHA f174e41View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.