This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
New data structure for miner transactions #2689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
miner-fix
branch
from
75c5d6d
to
8e73f27
Compare
ChrisSchinnerl
force-pushed
the
miner-fix
branch
from
8e73f27
to
737fb32
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a suggestion for a data structure that might help us avoid reordering transactions within the block after removing a transaction. It's essentially a double linked list.
Looking up a transaction by id, inserting a transaction and removing a transaction should all happen in constant time. After we are done modifying the transactions a call to
transactionsreturns a slice.Since the miner already has to go through all the transactions once before solving the block, looping over the transactions one more time to get the slice shouldn't impact performance.