This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
User-manual ‘disconnect’ adds a peer to a blacklist #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
gateway-blacklist
branch
from
afd79c0
to
606e8f7
Compare
modules/gateway/gateway.go
Outdated
| // Do the same for the blacklist. | ||
| if loadErr := g.loadBlacklist(); loadErr != nil && !os.IsNotExist(loadErr) { | ||
| return nil, loadErr | ||
| } |
There was a problem hiding this comment.
all persist loading should happen in load
| // Disconnect terminates a connection to a peer. | ||
| Disconnect(NetAddress) error | ||
|
|
||
| // DisconnectManual is a Disconnect wrapper for a user-initiated disconnect | ||
| DisconnectManual(NetAddress) error |
There was a problem hiding this comment.
why do we need these? Wouldn't a Blacklist method make more sense? It's not clear to me that a user-initiated disconnect always implies that the user wants to blacklist the peer.
As always, we may want to check how bitcoind solves these problems.
There was a problem hiding this comment.
I think bitcoind has a setban function that allows a user to ban a node for a certain period of time.
If we don't like this behaviour we can also change this PR to introduce a new endpoint. I started it because it was one of the todos.
There was a problem hiding this comment.
@DavidVorick any thoughts on that?
ChrisSchinnerl
force-pushed
the
gateway-blacklist
branch
from
29d54f0
to
395f8ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will cause a user initiated disconnect to blacklist a peer. The peer will only be blacklisted if it was actually connected to the node. For blacklisting nodes that are not connected we should probably add a separate endpoint (if we decide that we want that feature).
The blacklist is persisted in the
blacklist.jsonfile.