This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
[WIP] Improve unconfirmed txn handling in wallet #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
unconfirmed-txns-improv
branch
3 times, most recently
from
3740aea
to
2e85664
Compare
| @@ -24,6 +24,16 @@ func ComposeErrors(errs ...error) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // If there is only a single error return it directly. This still allows | |||
| // callers of functions to check for specific errors | |||
| if len(errStrings) == 1 { | |||
There was a problem hiding this comment.
this will have to be added to NebulousLabs/errors as well. We should make a PR that strips out build/errors.go.
There was a problem hiding this comment.
Maybe we should create an issue for that to make sure we don't forget about it.
|
The changes I made so far should allow the wallet to ignore certain errors returned by |
ChrisSchinnerl
force-pushed
the
unconfirmed-txns-improv
branch
from
3bed1a5
to
759c221
Compare
…uplicatTransactionSet
ChrisSchinnerl
force-pushed
the
unconfirmed-txns-improv
branch
from
9a1b1b1
to
c894976
Compare
ChrisSchinnerl
force-pushed
the
unconfirmed-txns-improv
branch
from
c894976
to
28a5e45
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wallet should be able to track transactions even if they haven't been accepted into the transaction set. For this to work, the wallet has to be able to add transactions to its set of unconfirmed transactions without relying on the transaction pool. This PR introduces a wrapper for
AcceptTransactionSetto achieve this.