auto hide modals on 'back' navigation #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry only noticed this PR a short time ago, does this prevent navigation or only hides the modals? per issue #446:
|
|
My bad I must have missed this. The second commit should prevent navigation now |
|
hmm i wonder if there's a cleaner way to solve it the modal might become closed via numerous ways (clicking off-screen, proceeding with action etc.) and even if we listen to modal events ( https://getuikit.com/docs/modal#javascript ) to catch 90% of them, it feels like we may still have undesired effects by adding fake history state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #446