Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.ios.ts to remove callback on cancel of DateTimePicker dialog. #277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrwrighty
Copy link

Removed callback(null) for cancelAction in iOS. If left in this results in datePickerClosed event being called.

Removed callback(null) for CancelAction in iOS. If left in results in datePickerClosed being called.
@cla-bot
Copy link

cla-bot bot commented May 24, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @mrwrighty.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@mrwrighty
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label May 24, 2022
@cla-bot
Copy link

cla-bot bot commented May 24, 2022

The cla-bot has been summoned, and re-checked this pull request!

@mrwrighty mrwrighty changed the title Update index.ios.ts Update index.ios.ts to remove callback on cancel of DateTimePicker dialog. May 24, 2022
@NathanWalker
Copy link
Contributor

Isn't a cancel a close though? Just wondering without anything to notify when canceled would leave out a way to respond to when the datepicker is no longer on screen, which you may want if doing other ui or data reactions when showing the datepicker. Idk?

@mrwrighty
Copy link
Author

Cancel is a close but still calls onDateChanged even though callback(null) is used. By removing the callback(null) the datetimepicker just closes with no event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants