#2490: skills-client theme - wip; added tests for skills progress; fi…

…xed today points on skill progress bars
NationalSecurityAgency · May 10, 2024 · e7987c6 · e7987c6
1 parent 559e7a0
commit e7987c6
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 1 deletion.
diff --git a/dashboard-prime/src/skills-display/components/progress/skill/SkillProgressBar.vue b/dashboard-prime/src/skills-display/components/progress/skill/SkillProgressBar.vue
@@ -35,9 +35,13 @@ const progressPercent = computed(() => {
   return totalPts
 })
 
+const progressBeforeToday = computed(() => {
+  return ((props.skill.points - props.skill.todaysPoints) / props.skill.totalPoints) * 100;
+})
+
 </script>
 <template>
-  <vertical-progress-bar :total-progress="progressPercent" :is-locked="isLocked">
+  <vertical-progress-bar :total-progress="progressPercent" :total-progress-before-today="progressBeforeToday" :is-locked="isLocked">
   </vertical-progress-bar>
 </template>
 

diff --git a/e2e-tests/cypress/e2e/client-display/client-display-theme-components_spec.js b/e2e-tests/cypress/e2e/client-display/client-display-theme-components_spec.js
@@ -126,6 +126,17 @@ describe('Client Display Theme Components Tests', () => {
             name: 'progressIndicators settings - completeColor'
         });
 
+        cy.cdClickSubj(0, 'Subject 1', true);
+        cy.matchSnapshotImageForElement('[data-cy="skillsProgressList"] [data-pc-section="body"]', {
+            name: 'progressIndicators settings - skill list - beforeTodayColor earnedTodayColor and incompleteColor'
+        });
+
+        cy.cdBack();
+        cy.cdClickSubj(2, 'Completed', false);
+        cy.matchSnapshotImageForElement('[data-cy="skillsProgressList"] [data-pc-section="body"]', {
+            name: 'progressIndicators settings - skill list - completeColor'
+        });
+
     });
 
     it.skip('point history chart - line, label and gradient', () => {

diff --git a/...ttings - skill list - beforeTodayColor earnedTodayColor and incompleteColor.png b/...ttings - skill list - beforeTodayColor earnedTodayColor and incompleteColor.png
diff --git a/...components_spec.js/progressIndicators settings - skill list - completeColor.png b/...components_spec.js/progressIndicators settings - skill list - completeColor.png