#2490: test fixes

NationalSecurityAgency · May 8, 2024 · 72a0c96 · 72a0c96
1 parent 788af97
commit 72a0c96
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 3 deletions.
diff --git a/dashboard-prime/src/skills-display/components/badges/BadgeDetailsPage.vue b/dashboard-prime/src/skills-display/components/badges/BadgeDetailsPage.vue
@@ -68,9 +68,8 @@ const locked = computed(() => {
           </a>
         </template>
       </Card>
-
       <skills-progress-list
-        v-if="badge && !(skillsDisplayInfo.isGlobalBadgePage.value && !summaryAndSkillsState.subjectSummary?.skills)"
+        v-if="badge && !(skillsDisplayInfo.isGlobalBadgePage.value && !(summaryAndSkillsState.subjectSummary?.skills?.length > 0))"
         :subject="badge"
         type="badge"
         class="mt-3"

diff --git a/e2e-tests/cypress/e2e/client-display/client-display_breadcrumb_spec.js b/e2e-tests/cypress/e2e/client-display/client-display_breadcrumb_spec.js
@@ -371,7 +371,7 @@ describe('Client Display Breadcrumb Tests', () => {
         cy.get('[data-cy="skillsDisplayBreadcrumbBar"] [data-cy=breadcrumbLink-Overview]')
             .should('have.attr', 'href');
         cy.get('[data-cy=skillsDisplayBreadcrumbBar]')
-            .contains(new RegExp(/^Overview.*Subject:\s*subj1.*Skill:\s*skill3.*Dependency:\s*skill1$/))
+            .contains(new RegExp(/^Overview.*Subject:\s*subj1.*Skill:\s*skill3.*Prerequisite:\s*skill1$/))
             .should('be.visible');
         cy.get('[data-cy="skillsDisplayBreadcrumbBar"] [data-cy="breadcrumbItemValue"]')
             .its('length')

diff --git a/...base/client-display_leaderboard_sharedData_spec.js/leaderboard 10 Around Me.png b/...base/client-display_leaderboard_sharedData_spec.js/leaderboard 10 Around Me.png
diff --git a/...ssion/base/client-display_leaderboard_sharedData_spec.js/leaderboard top 10.png b/...ssion/base/client-display_leaderboard_sharedData_spec.js/leaderboard top 10.png
diff --git a/...ession/base/client-display_leaderboard_sharedData_spec.js/my-rank-opted-out.png b/...ession/base/client-display_leaderboard_sharedData_spec.js/my-rank-opted-out.png
diff --git a/...isplay-prerequisites_spec.js/skill with dependency renders dependency graph.png b/...isplay-prerequisites_spec.js/skill with dependency renders dependency graph.png