Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove c keywords when parsing function signatures #6462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

astrelsky
Copy link
Contributor

This makes life much easier since you can just copy/paste the signature from source.

@ryanmkurtz ryanmkurtz added the Status: Triage Information is being gathered label Apr 30, 2024
@ghidra1 ghidra1 assigned ghidragon and unassigned ghidra1 Apr 30, 2024
@ghidra1
Copy link
Collaborator

ghidra1 commented Apr 30, 2024

It is not a C Parser. How do you expect it to handle something like unsigned int?

@ghidragon ghidragon added Status: Prioritize This is currently being prioritized and removed Status: Triage Information is being gathered labels Apr 30, 2024
@astrelsky
Copy link
Contributor Author

astrelsky commented Apr 30, 2024

It is not a C Parser. How do you expect it to handle something like unsigned int?

The same way it did before. All the changes here do is remove the C keywords Ghidra doesn't support.

I don't know why I didn't specify this initially. Sorry about that.

@ghidra1
Copy link
Collaborator

ghidra1 commented May 2, 2024 via email

@ghidra1
Copy link
Collaborator

ghidra1 commented May 2, 2024 via email

@ghidra007 ghidra007 assigned ghidra1 and unassigned ghidragon May 2, 2024
@ghidra007 ghidra007 added Status: Internal This is being tracked internally by the Ghidra team and removed Status: Prioritize This is currently being prioritized labels May 2, 2024
@ghidra1
Copy link
Collaborator

ghidra1 commented May 2, 2024 via email

@ghidra1
Copy link
Collaborator

ghidra1 commented May 2, 2024 via email

@ghidra1
Copy link
Collaborator

ghidra1 commented May 2, 2024 via email

@astrelsky
Copy link
Contributor Author

If you prefer, I can add this to my cue and address in a more appropriate fashion.

That's fine with me.

The "inline" modifier should probably be handled separately so that it can toggle the function's inline flag and should not apply to all data type parsing

I'm not convinced it should. Mainly because if it is a separate function in the resulting program, then the compiler decided not to inline it and it actually is a function call in the original code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Internal This is being tracked internally by the Ghidra team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants