Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tricore instruction st.da circular addr mode #6456

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rbran
Copy link
Contributor

@rbran rbran commented Apr 23, 2024

At the manual https://www.infineon.com/dgdl/tc_v131_instructionset_v138.pdf?fileId=db3a304412b407950112b409b6dd0352
It defines word as 32bits, and the instruction define a memory write of word len (M(EA0, word) = A[a];, so those are two 4bytes writes and not 2bytes writes

At the manual https://www.infineon.com/dgdl/tc_v131_instructionset_v138.pdf?fileId=db3a304412b407950112b409b6dd0352
It defines word as 32bits, and the instruction define a memory write of word len `(M(EA0, word) = A[a];`, so those are two 4bytes writes and not 2bytes writes
@ryanmkurtz ryanmkurtz added Feature: Processor/Tricore Status: Triage Information is being gathered labels Apr 23, 2024
@GhidorahRex GhidorahRex added Status: Internal This is being tracked internally by the Ghidra team and removed Status: Triage Information is being gathered labels Apr 23, 2024
@mumbel
Copy link
Contributor

mumbel commented Apr 24, 2024

good catch. I knew what I wanted to do on the RHS at least :D

This bug class doesn't have any compiler warning/error/debug sadly, I've come across a few bugs lately in other languages where the LHS size doesn't match RHS

@rbran
Copy link
Contributor Author

rbran commented Apr 24, 2024

@mumbel I found this bug while testing the variable size checker at sleigh-rs, maybe one day I'll be able to finish implement it, and make a LSP out of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Processor/Tricore Status: Internal This is being tracked internally by the Ghidra team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants