Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ARMEmulateInstructionStateModifier.java #6419

Closed
wants to merge 1 commit into from

Commits on Apr 14, 2024

  1. Update ARMEmulateInstructionStateModifier.java

    Reasons for changes:
    
    Method Extraction: Moved register initialization into a separate method to improve readability and maintainability. This makes the constructor cleaner and easier to understand.
    
    Simplified Conditionals: Simplified conditional checks in initialExecuteCallback and postExecuteCallback for better clarity and readability. This reduces cognitive load for developers who need to understand the logic at a glance.
    
    Modularization: Extracted logic for handling thumb mode and ARM mode into separate methods to improve modularity and readability. This makes each method focus on a single responsibility, making the code easier to understand and maintain.
    
    Removed Unnecessary Comments: Removed unnecessary comments for improved code readability. Comments should only be used when they add valuable information or clarification, not for restating what the code does.
    r0cketdyne committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    ae2dc4b View commit details
    Browse the repository at this point in the history