decompiler-cpp: Open sla files as 'binary' #6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compressed files need to be opened as binaries when reading. Fixes opening sla files on Windows.
This was referenced Apr 1, 2024
Merged
ryanmkurtz
added
Feature: Decompiler
Status: Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compressed files need to be opened as binaries when reading. Fixes opening sla files on Windows.
Found and fixed after having issues in lifting-bits/sleigh#245 (particularly issues from commit 8fbd171) where only Windows tests were failing. You can see when the CI turns green near the bottom of the PR page. This bug took a while to find.
Related to