GP-4584 Corrected FID and ConstantPropogator errors (Closes #6453)

NationalSecurityAgency · May 8, 2024 · b8b0bee · b8b0bee
1 parent c4ea004
commit b8b0bee
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/Ghidra/Features/Base/src/main/java/ghidra/program/util/SymbolicPropogator.java b/Ghidra/Features/Base/src/main/java/ghidra/program/util/SymbolicPropogator.java
@@ -1744,7 +1744,9 @@ private PcodeOp[] doCallOtherPcodeInjection(Instruction instr, Varnode ins[], Va
 		con.refAddr = con.callAddr;
 		con.inputlist = inputs;
 		con.output = new ArrayList<Varnode>();
-		con.output.add(out);
+		if (out != null) {
+			con.output.add(out);
+		}
 		try {
 			return payload.getPcode(prog, con);
 		}

diff --git a/...Features/FunctionID/src/main/java/ghidra/feature/fid/service/FidServiceLibraryIngest.java b/...Features/FunctionID/src/main/java/ghidra/feature/fid/service/FidServiceLibraryIngest.java
@@ -30,8 +30,7 @@
 import ghidra.program.model.address.*;
 import ghidra.program.model.lang.*;
 import ghidra.program.model.listing.*;
-import ghidra.program.model.mem.MemoryAccessException;
-import ghidra.program.model.mem.MemoryBlock;
+import ghidra.program.model.mem.*;
 import ghidra.program.model.symbol.*;
 import ghidra.util.Msg;
 import ghidra.util.exception.CancelledException;
@@ -619,15 +618,13 @@ private boolean checkLanguageCompilerSpec(Program program) {
 	 * @return whether the function is external
 	 */
 	private static boolean functionIsExternal(Function function) {
-		if (function.isExternal()) {
-			return true;
-		}
+		Memory mem = function.getProgram().getMemory();
 		Address entryPoint = function.getEntryPoint();
-		MemoryBlock block = function.getProgram().getMemory().getBlock(entryPoint);
-		if (!block.isInitialized()) {
+		if (function.isExternal() || !mem.contains(entryPoint)) {
 			return true;
 		}
-		return false;
+		MemoryBlock block = function.getProgram().getMemory().getBlock(entryPoint);
+		return block == null || !block.isInitialized() || block.isExternalBlock();
 	}
 
 	private void exclude(DomainFile domainFile, Function function,