Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutdown RollManager before ResourceWatcher #764

Merged
merged 4 commits into from May 1, 2024
Merged

shutdown RollManager before ResourceWatcher #764

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd09559
move ResourceWatcher to shutdown after MetricManager
sambish5 Apr 26, 2024
b635b51
move RollManager also to shutdown before ResourceWatcher
sambish5 Apr 26, 2024
63b4bd4
Move RollManager to shutdown prior to MetricsManager
sambish5 Apr 29, 2024
b1911ea
restore MetricsManager shutdown location
jpdahlke Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/main/java/emissary/server/EmissaryServer.java
View file
Open in desktop
Expand Up @@ -366,6 +366,14 @@ public static void stopServer(final String name, final boolean force, final bool
}
LOG.info("Done stopping all places");

try {
MetricsManager.lookup().shutdown();
} catch (Exception ex) {
LOG.warn("No metrics manager available");
}

sambish5 marked this conversation as resolved.
Show resolved Hide resolved
RollManager.shutdown();
sambish5 marked this conversation as resolved.
Show resolved Hide resolved

// Print the stats
try {
ResourceWatcher rw = ResourceWatcher.lookup();
Expand All @@ -375,16 +383,8 @@ public static void stopServer(final String name, final boolean force, final bool
LOG.warn("No resource statistics available");
}

try {
MetricsManager.lookup().shutdown();
} catch (Exception ex) {
LOG.warn("No metrics manager available");
}

SPILoader.unload();

RollManager.shutdown();

LOG.info("Done stopping all services");

// thread dump now
Expand Down