Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using ubi as the standard github build with Docker #761

Closed
wants to merge 21 commits into from

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Apr 24, 2024

No description provided.

@dev-mlb dev-mlb marked this pull request as ready for review April 24, 2024 15:03
@cfkoehler cfkoehler self-requested a review April 24, 2024 20:54
@cfkoehler cfkoehler added the CI/CD Changes to the CI/CD Pipeline label Apr 25, 2024
@cfkoehler
Copy link
Collaborator

Not needed here. But believe this changes a few of the steps in DEVELOPING.md for using docker

mvn clean install -Pdist

Basically no longer needing to run a maven build first since it is done in the image build process.

cfkoehler
cfkoehler previously approved these changes Apr 25, 2024
.github/workflows/maven-ci.yml Show resolved Hide resolved
@dev-mlb dev-mlb requested a review from cfkoehler April 25, 2024 11:37
cfkoehler
cfkoehler previously approved these changes Apr 25, 2024
@cfkoehler cfkoehler requested a review from ldhardy April 25, 2024 17:56
@jpdahlke jpdahlke added this to the v8.2.0 milestone Apr 25, 2024
@jpdahlke jpdahlke requested a review from cfkoehler April 26, 2024 12:02
@jpdahlke
Copy link
Collaborator

This seems like a good change to me. Once this is in we can update the settings to require the actions to complete for merge.

@dev-mlb dev-mlb mentioned this pull request Apr 27, 2024
@jpdahlke
Copy link
Collaborator

in favor of #765

@jpdahlke jpdahlke closed this Apr 30, 2024
@jpdahlke jpdahlke removed this from the v8.2.0 milestone Apr 30, 2024
@dev-mlb dev-mlb deleted the build-testing branch May 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Changes to the CI/CD Pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants