Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed DateTimeFormatParserLegacy #719

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Removed DateTimeFormatParserLegacy #719

wants to merge 3 commits into from

Conversation

nixon124
Copy link
Collaborator

No description provided.

sambish5
sambish5 previously approved these changes Mar 13, 2024
View reviewed changes
@cfkoehler cfkoehler added this to the v8.0.0-M16 milestone Mar 13, 2024
@arp-0984 arp-0984 self-requested a review March 13, 2024 20:10
arp-0984
arp-0984 requested changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@arp-0984 arp-0984 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a reference to DateTimeFormatParserLegacy in a comment in DateTimeFormatParser.cfg. Can you remove this as well?

arp-0984
arp-0984 previously approved these changes Mar 14, 2024
View reviewed changes
sambish5
sambish5 previously approved these changes Mar 18, 2024
View reviewed changes
@jpdahlke jpdahlke modified the milestones: v8.0.0-M16, v8.0.0 Mar 18, 2024
@dev-mlb dev-mlb added the rebase Things have happened and now a rebase is needed label Mar 20, 2024
@jpdahlke jpdahlke modified the milestones: v8.0.0, v8.1.0 Mar 25, 2024
@nixon124 nixon124 dismissed stale reviews from sambish5 and arp-0984 via e9e4866 March 29, 2024 12:47
sambish5
sambish5 previously approved these changes Mar 29, 2024
View reviewed changes
@arp-0984
Copy link
Collaborator

I'm not sure if something got messed up during the rebase, but I don't see all of the changes -- I only see removing the comment from DateTimeFormatParser.cfg

@sambish5 sambish5 self-requested a review March 29, 2024 13:45
@jpdahlke jpdahlke removed this from the v8.1.0 milestone Apr 2, 2024
@dev-mlb dev-mlb removed the rebase Things have happened and now a rebase is needed label Apr 5, 2024
@jpdahlke
Copy link
Collaborator

jpdahlke commented Apr 6, 2024

  • Awaiting internal testing to prove safe removal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drivenflywheel drivenflywheel drivenflywheel approved these changes

@sambish5 sambish5 sambish5 approved these changes

@arp-0984 arp-0984 arp-0984 approved these changes

@dev-mlb dev-mlb Awaiting requested review from dev-mlb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nixon124 @arp-0984 @jpdahlke @drivenflywheel @sambish5 @dev-mlb @cfkoehler