errorprone :: MissingOverride & RedundantOverride (#772)

NationalSecurityAgency · May 10, 2024 · 65add6d · 65add6d
1 parent 58d57d7
commit 65add6d
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 5 deletions.
diff --git a/src/main/java/emissary/core/TransformHistory.java b/src/main/java/emissary/core/TransformHistory.java
@@ -209,6 +209,7 @@ public boolean wasCoordinated() {
             return coordinated;
         }
 
+        @Override
         public String toString() {
             String start;
             if (wasCoordinated()) {

diff --git a/src/main/java/emissary/core/sentinel/protocols/rules/AllMaxTime.java b/src/main/java/emissary/core/sentinel/protocols/rules/AllMaxTime.java
@@ -29,6 +29,7 @@ public AllMaxTime(String name, String place, String timeLimit, String threshold)
      * @param placeAgentStats the stats of a place that is currently processing
      * @return true if any places in mobile agents are over the configured time limit, false otherwise
      */
+    @Override
     protected boolean overTimeLimit(Collection<Protocol.PlaceAgentStats> placeAgentStats) {
         long minTimeInPlace = placeAgentStats.stream().mapToLong(Protocol.PlaceAgentStats::getMinTimeInPlace).min().orElse(0);
         logger.debug("Testing timeLimit for place={}, minTime={}, timeLimit={}", place, minTimeInPlace, timeLimit);

diff --git a/src/main/java/emissary/core/sentinel/protocols/rules/AnyMaxTime.java b/src/main/java/emissary/core/sentinel/protocols/rules/AnyMaxTime.java
@@ -29,6 +29,7 @@ public AnyMaxTime(String name, String place, String timeLimit, String threshold)
      * @param placeAgentStats the stats of a place that is currently processing
      * @return true if any places in mobile agents are over the configured time limit, false otherwise
      */
+    @Override
     protected boolean overTimeLimit(Collection<Protocol.PlaceAgentStats> placeAgentStats) {
         long maxTimeInPlace = placeAgentStats.stream().mapToLong(Protocol.PlaceAgentStats::getMaxTimeInPlace).max().orElse(0);
         logger.debug("Testing timeLimit for place={}, maxTime={}, timeLimit={}", place, maxTimeInPlace, timeLimit);

diff --git a/src/main/java/emissary/place/ServiceProviderPlace.java b/src/main/java/emissary/place/ServiceProviderPlace.java
@@ -1121,6 +1121,7 @@ protected IBaseDataObject getTLD() {
         return null;
     }
 
+    @Override
     public boolean isDenied(String s) {
         return denyList.contains(s);
     }

diff --git a/src/main/java/emissary/util/shell/Executrix.java b/src/main/java/emissary/util/shell/Executrix.java
@@ -1330,6 +1330,7 @@ public SbExecuteConfig(String[] cmd, byte[] data, StringBuilder out, StringBuild
                 this.out = out;
             }
 
+            @Override
             public ProcessReader getStdOutProcessReader(Process p) {
                 return out == null ? super.getStdOutProcessReader(p) : new ReadOutputBuffer(p.getInputStream(), out);
             }
@@ -1345,6 +1346,7 @@ public BaosExecuteConfig(String[] cmd, byte[] data, ByteArrayOutputStream out, S
                 this.out = out;
             }
 
+            @Override
             public ProcessReader getStdOutProcessReader(Process p) {
                 return out == null ? super.getStdOutProcessReader(p) : new ReadBinaryOutputBuffer(p.getInputStream(), out);
             }

diff --git a/src/main/java/emissary/util/shell/ProcessReader.java b/src/main/java/emissary/util/shell/ProcessReader.java
@@ -39,6 +39,7 @@ protected final void applyLogContextMap() {
      * Wrapper method to ensure that the {@link #applyLogContextMap()} method is always invoked before executing the core
      * functionality of ProcessReader subclasses
      */
+    @Override
     public void run() {
         applyLogContextMap();
         runImpl();

diff --git a/src/test/java/emissary/pickup/file/FilePickUpClientTest.java b/src/test/java/emissary/pickup/file/FilePickUpClientTest.java
@@ -151,10 +151,5 @@ protected String caseIdHook(String initialCaseId, String sessionname, String fil
                 return super.caseIdHook(initialCaseId, sessionname, fileName, metadata);
             }
         }
-
-        @Override
-        protected String createFilename(String filePath, String prefix) {
-            return super.createFilename(filePath, prefix);
-        }
     }
 }