Fixed bug where unique results of null values failed to return #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ivakegg
commented
Apr 19, 2024
ivakegg
commented
- The intermedite results mechanism which got fixed with the most recent unique mechanism resulted in this bug
* The intermedite results mechanism which got fixed with the most recent unique mechanism resulted in this bug
ivakegg
commented
Apr 19, 2024
| * The query model | ||
| */ | ||
| private void setModelMappings(QueryModel model) { | ||
| if (model != null) { |
There was a problem hiding this comment.
This whole mapping is already done in the DefaultQueryPlanner when setting up the query fields. This was redundant.
ivakegg
commented
Apr 19, 2024
| if (!values.isEmpty()) { | ||
| Collections.sort(values); | ||
| String separator = "f-" + field + '/' + (count++) + ":"; |
There was a problem hiding this comment.
Adding the count in here is not really useful.
ivakegg
commented
Apr 19, 2024
| if (keyDocumentEntry.getValue().isIntermediateResult()) { | ||
| return keyDocumentEntry; | ||
| } | ||
|
|
There was a problem hiding this comment.
This was the critical piece to fix the null document issue.
hlgp
reviewed
Apr 19, 2024
warehouse/query-core/src/test/java/datawave/query/transformer/UniqueTransformTest.java
Outdated
Show resolved
Hide resolved
apmoriarty
approved these changes
Apr 22, 2024
avgAGB
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.