Age off modulation and new formatting utility #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matthpeterson
commented
Mar 22, 2024
•
matthpeterson
commented
- Extracts age-off code and tests to its own module
- Creates a new module containing age-off related utilities, such as generation of xml configuration files from a csv
- Ensures no transitive dependencies in new modules
- Eliminates transitive dependencies from common-test
matthpeterson
force-pushed
the
csv-to-match-pattern
branch
3 times, most recently
from
b7aa731
to
e4e5fd5
Compare
matthpeterson
requested review from
jschmidt10,
keith-ratcliffe,
jwomeara,
hlgp and
dtspence
matthpeterson
force-pushed
the
csv-to-match-pattern
branch
from
e80bec4
to
672b093
Compare
jschmidt10
reviewed
Mar 26, 2024
warehouse/age-off-utils/src/main/java/datawave/age/off/util/AgeOffFileGenerator.java
Show resolved
Hide resolved
jschmidt10
reviewed
Mar 26, 2024
warehouse/age-off-utils/src/main/java/datawave/age/off/util/AgeOffRuleConfiguration.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Mar 26, 2024
warehouse/age-off-utils/src/main/java/datawave/age/off/util/AgeOffFileGenerator.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Mar 26, 2024
...ouse/age-off-utils/src/main/java/datawave/age/off/util/AgeOffCsvToMatchPatternFormatter.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Mar 26, 2024
...utils/src/main/java/datawave/age/off/util/AgeOffCsvToMatchPatternFormatterConfiguration.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Mar 26, 2024
...ouse/age-off-utils/src/main/java/datawave/age/off/util/AgeOffCsvToMatchPatternFormatter.java
Show resolved
Hide resolved
jschmidt10
reviewed
Mar 26, 2024
.../age-off-utils/src/test/java/datawave/age/off/util/AgeOffCsvToMatchPatternFormatterTest.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Mar 26, 2024
.../age-off-utils/src/test/java/datawave/age/off/util/AgeOffCsvToMatchPatternFormatterTest.java
Outdated
Show resolved
Hide resolved
matthpeterson
changed the title
jschmidt10
previously approved these changes
Apr 19, 2024
matthpeterson
changed the title
dtspence
previously approved these changes
Apr 22, 2024
matthpeterson
force-pushed
the
csv-to-match-pattern
branch
from
0b02d62
to
cc9086c
Compare
added 5 commits
May 2, 2024 20:23
…ule Removed unneeded dependencies and transitive dependencies from poms, added scope and comment for each
added 12 commits
May 2, 2024 20:23
matthpeterson
force-pushed
the
csv-to-match-pattern
branch
from
103af34
to
7809265
Compare
matthpeterson
changed the title
jschmidt10
approved these changes
May 3, 2024
dtspence
approved these changes
May 3, 2024
hgklohr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.