Added QueryLogIterator class #2322
Conversation
| protected static final Logger log = Logger.getLogger(QueryLogIterator.class); | ||
|
|
||
| protected SortedKeyValueIterator<Key,Value> source; | ||
| protected SortedKeyValueIterator<Key,Value> sourceForDeepCopies; |
There was a problem hiding this comment.
sourceForDeepCopies not needed, not used. Same goes for initKeySource, seekKeySource, myEnvironment, and queryOptions.
There was a problem hiding this comment.
What we should be doing is attempting to pull the query id from the queryOptions for use in log messages.
There was a problem hiding this comment.
That would be better than stoiring the entire map of options.
| protected NestedIterator<Key> initKeySource, seekKeySource; | ||
| protected IteratorEnvironment myEnvironment; | ||
|
|
||
| protected Range range; |
There was a problem hiding this comment.
No need for Range, Key, Value, and yield
| public void init(SortedKeyValueIterator<Key,Value> source, Map<String,String> options, IteratorEnvironment env) throws IOException { | ||
|
|
||
| try{ | ||
| if (log.isInfoEnabled()) { |
There was a problem hiding this comment.
Perhaps a "start" method that takes in the name of the method . That would make the code a lot simpler. Also this method could be the one that sets the thread name.
| this.source = source; | ||
| } | ||
| finally{ | ||
| if (log.isInfoEnabled()) { |
There was a problem hiding this comment.
Perhaps an "end" method akin to the start method. Also this method could be the one that resets the thread name to its original form.
| try { | ||
| if(log.isInfoEnabled()){ | ||
| log.info("QueryLogIterator: deepCopy() Started QueryID: " + this.queryOptions.get(QUERY_ID)); | ||
| newQLI = new QueryLogIterator(this, this.myEnvironment); |
There was a problem hiding this comment.
move outside the if clause here.
| try { | ||
| if(log.isInfoEnabled()){ | ||
| log.info("QueryLogIterator: seek() Started QueryID: " + this.queryOptions.get(QUERY_ID)); | ||
| this.source.seek(range, collection, b); |
There was a problem hiding this comment.
move outside of the if clause
| @@ -467,9 +472,14 @@ protected CloseableIterable<QueryData> process(ScannerFactory scannerFactory, Me | |||
| cfg = getQueryIterator(metadataHelper, config, settings, "", false, false); | |||
| } | |||
| configureIterator(config, cfg, newQueryString, isFullTable); | |||
|
|
|||
| while (null == logCfg) { | |||
| logCfg = getQueryIterator(metadataHelper, config, settings, "", false, false); | |||
There was a problem hiding this comment.
I think this should be getQueryLogIterator
| @@ -437,6 +439,7 @@ public class QueryOptions implements OptionDescriber { | |||
|
|
|||
| private Map<String,Long> fieldCounts; | |||
| private Map<String,Long> termCounts; | |||
| private boolean activeTserverLogging = false; | |||
There was a problem hiding this comment.
lets make this "true" by default
| @@ -469,6 +469,8 @@ public class ShardQueryConfiguration extends GenericQueryConfiguration implement | |||
| */ | |||
| private boolean useTermCounts = false; | |||
|
|
|||
| private boolean isTserverLoggingActive = false; | |||
There was a problem hiding this comment.
lets make this true by default
SethSmucker
force-pushed
the
log-iterator
branch
from
eb03cbf
to
fff761e
Compare
Added a QueryLogIterator class. This iterator logs the QueryID and method name called before and after each method is executed by the following iterator.