fix build warning messages #2277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-ratcliffe
requested changes
Feb 14, 2024
...vices/cached-results/src/main/java/datawave/webservice/results/cached/CachedResultsBean.java
Outdated
Show resolved
Hide resolved
...house/ingest-core/src/main/java/datawave/ingest/mapreduce/job/MultiRFileOutputFormatter.java
Outdated
Show resolved
Hide resolved
warehouse/ingest-json/src/main/java/datawave/ingest/json/config/helper/JsonDataTypeHelper.java
Outdated
Show resolved
Hide resolved
warehouse/ingest-json/src/main/java/datawave/ingest/json/config/helper/JsonDataTypeHelper.java
Outdated
Show resolved
Hide resolved
cogross
force-pushed
the
2261-fix-build-warning
branch
3 times, most recently
from
5c439b7
to
af88dc7
Compare
keith-ratcliffe
previously approved these changes
Feb 15, 2024
cogross
force-pushed
the
2261-fix-build-warning
branch
from
af88dc7
to
4428223
Compare
avgAGB
previously approved these changes
Feb 16, 2024
cogross
force-pushed
the
2261-fix-build-warning
branch
5 times, most recently
from
4fd7e94
to
280403a
Compare
cogross
force-pushed
the
2261-fix-build-warning
branch
2 times, most recently
from
57b4780
to
ee4b108
Compare
mineralntl
previously approved these changes
Feb 28, 2024
cogross
force-pushed
the
2261-fix-build-warning
branch
from
ee4b108
to
3336b96
Compare
cogross
force-pushed
the
2261-fix-build-warning
branch
6 times, most recently
from
2da441a
to
3609a63
Compare
cogross
force-pushed
the
2261-fix-build-warning
branch
3 times, most recently
from
8e9f7e7
to
af8c162
Compare
cogross
force-pushed
the
2261-fix-build-warning
branch
5 times, most recently
from
7550e13
to
02cda16
Compare
ivakegg
reviewed
Apr 9, 2024
| @@ -43,6 +43,8 @@ public abstract class UID implements Comparable<UID>, Comparator<UID>, Writable, | |||
|
|
|||
| private static final Logger LOGGER = Logger.getLogger(UID.class); | |||
|
|
|||
| private static final long serialVersionUID = 0L; | |||
There was a problem hiding this comment.
should we be computing a more reasonable serial version UID ? Same comment for everywhere else we use 0L
cogross
force-pushed
the
2261-fix-build-warning
branch
2 times, most recently
from
6885261
to
6e5037c
Compare
cogross
force-pushed
the
2261-fix-build-warning
branch
4 times, most recently
from
c3a6e8f
to
6a40151
Compare
cogross
force-pushed
the
2261-fix-build-warning
branch
3 times, most recently
from
16a6e2c
to
be5edc4
Compare
cogross
force-pushed
the
2261-fix-build-warning
branch
5 times, most recently
from
48d2c18
to
a630599
Compare
cogross
force-pushed
the
2261-fix-build-warning
branch
4 times, most recently
from
a1f8e95
to
2af1681
Compare
added 2 commits
May 21, 2024 17:13
cogross
force-pushed
the
2261-fix-build-warning
branch
from
2af1681
to
ec2cf1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clears up a number of simple warnings that occur during the build.
(another ticket will cover more of the complex ones that would need a bit of refactoring)