Feature/query microservices #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via the spring boot datawave query starter.
… datawave ws common
…e, cancel locking logic.
… the hazelcast cache
…ory structure for the query-executor.
- Updated Query Json Serialization to be polymorphic. - Updated Query Json Serialization to serialize the query as a string. - Created a ProxiedUserEntity-specific AuthorizationsUtil to avoid usage of DatawavePrincipal. - Updated all query microservices to use the spring-boot provided log4j dependencies. - Moved Local query storage cache implementation to test and created a test jar. - Renamed the query cache dependency to query-storage to be consistent with the api and parent modules. - Renamed various application launcher classes to be consistent with our existing microservices. - Removed Autowired injection for components where a constructor would suffice. - Updated QueryTaskNotification to have it be published via the spring cloud bus. - Many other various changes/improvements.
…pdated QueryStorageCacheTest to work with an external rabbitmq
… action. Renamed the query status cache to CachedQueryStatus.
…equest objects instead of TaskNotification objects.
…ryid and query pool to be String objects for avoid excessive object creations and conversions.
… been retrieved for a query.
…is closed. Updated to adjust the number of results to generate capped by max results. Added test cases to verify we generate results as appropriate (ShouldGenerateResultsTest) Updated a bunch of javadoc to remove all warnings
Fixed some kafka query queue manager mechanisms and reenabled tests.
… and updated the query service to include that file as a resource.
apmoriarty
reviewed
Apr 30, 2024
src/main/java/datawave/microservice/query/storage/QueryStatus.java
Outdated
Show resolved
Hide resolved
alerman
reviewed
Apr 30, 2024
| @ConfigurationPropertiesBinding | ||
| public class StringToTypeConverter implements Converter<String,Type> { | ||
| @Override | ||
| public Type convert(String source) { |
There was a problem hiding this comment.
Is there not method like this in a library? Not necessarily saying we use it, just seems like it would be code that is duplicated. Maybe thats ok.
There was a problem hiding this comment.
Hmmm, i'm not sure. This is specifically used to map yaml spring properties to actual datawave Types, so im not sure that's something we've done before. Looking in the type-utils project, I'm not seeing anything at first glance that could serve this purpose.
apmoriarty
reviewed
Apr 30, 2024
src/main/java/datawave/microservice/query/storage/CachedQueryStatus.java
Outdated
Show resolved
Hide resolved
alerman
reviewed
Apr 30, 2024
src/main/java/datawave/microservice/query/messaging/kafka/KafkaQueryResultsManager.java
Outdated
Show resolved
Hide resolved
alerman
reviewed
Apr 30, 2024
src/main/java/datawave/microservice/query/messaging/kafka/KafkaQueryResultsManager.java
Outdated
Show resolved
Hide resolved
alerman
reviewed
Apr 30, 2024
src/main/java/datawave/microservice/query/messaging/rabbitmq/RabbitMQQueryResultsPublisher.java
Show resolved
Hide resolved
alerman
reviewed
Apr 30, 2024
src/main/java/datawave/microservice/query/messaging/rabbitmq/RabbitMQQueryResultsPublisher.java
Outdated
Show resolved
Hide resolved
alerman
reviewed
Apr 30, 2024
src/main/java/datawave/microservice/query/storage/TaskStates.java
Outdated
Show resolved
Hide resolved
alerman
reviewed
Apr 30, 2024
src/main/java/datawave/microservice/query/storage/TaskStates.java
Outdated
Show resolved
Hide resolved
ivakegg
reviewed
May 1, 2024
ivakegg
reviewed
May 1, 2024
cogross
reviewed
May 2, 2024
src/main/java/datawave/microservice/query/mapreduce/jobs/MapReduceJob.java
Show resolved
Hide resolved
cogross
reviewed
May 2, 2024
src/main/java/datawave/microservice/query/mapreduce/jobs/MapReduceJob.java
Show resolved
Hide resolved
cogross
reviewed
May 3, 2024
src/main/java/datawave/microservice/query/storage/QueryStatus.java
Outdated
Show resolved
Hide resolved
cogross
reviewed
May 3, 2024
src/main/java/datawave/microservice/query/storage/QueryStorageCacheImpl.java
Outdated
Show resolved
Hide resolved
cogross
reviewed
May 3, 2024
src/main/java/datawave/microservice/query/storage/TaskStates.java
Outdated
Show resolved
Hide resolved
avgAGB
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.