Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade Simplemma #724

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: Upgrade Simplemma #724

wants to merge 3 commits into from

Conversation

osma
Copy link
Member

@osma osma commented Aug 10, 2023

This draft PR upgrades Simplemma to the latest version, currently pointing to the main branch on github. The idea is to test if changes in simplemma made after the last release 0.9.1 affect Annif. See adbar/simplemma#110

This PR cannot be merged until there has been a new release of Simplemma that we can point to.

@osma osma added this to the 1.0 milestone Aug 10, 2023
@osma osma self-assigned this Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e9031bb) 99.67% compared to head (ec7d640) 99.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          89       90    +1     
  Lines        6397     6407   +10     
=======================================
+ Hits         6376     6386   +10     
  Misses         21       21           
Files Changed Coverage Δ
annif/analyzer/simplemma.py 100.00% <100.00%> (ø)
annif/simplemma_util.py 100.00% <100.00%> (ø)
annif/transform/langfilter.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants