fix(select): keep ngModel when selected option is recreated with ngRe…

…peat Fixes angular#15630
Narretz · Jan 26, 2017 · 2d7e08e · 2d7e08e
1 parent 641e13a
commit 2d7e08e
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/ng/directive/select.js b/src/ng/directive/select.js
@@ -281,7 +281,7 @@ var SelectController =
       var removeValue = optionAttrs.value;
 
       self.removeOption(removeValue);
-      self.ngModelCtrl.$render();
+      scheduleRender();
 
       if (self.multiple && currentValue && currentValue.indexOf(removeValue) !== -1 ||
           currentValue === removeValue

diff --git a/test/ng/directive/selectSpec.js b/test/ng/directive/selectSpec.js
@@ -2316,6 +2316,34 @@ describe('select', function() {
 
       });
 
+      it('should keep the ngModel value when the selected option is recreated by ngRepeat', function() {
+
+          scope.options = ['A', 'B', 'C'];
+          scope.obj = {
+            value: 'B'
+          };
+
+          compile(
+            '<select ng-model="obj.value">' +
+              '<option ng-repeat="option in options" value="{{option}}">{{option}}</option>' +
+            '</select>'
+          );
+
+          var optionElements = element.find('option');
+          expect(optionElements.length).toEqual(3);
+          expect(optionElements[0].value).toBe('A');
+          expect(optionElements[1]).toBeMarkedAsSelected();
+
+          scope.$apply(function() {
+            scope.options = ['B', 'C', 'D'];
+          });
+
+          optionElements = element.find('option');
+          expect(optionElements.length).toEqual(3);
+          expect(optionElements[0].value).toBe('B');
+          expect(optionElements[0]).toBeMarkedAsSelected();
+      });
+
     });